Skip to content

Remove json:omitempty from required fields #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Remove json:omitempty from required fields #4018

merged 1 commit into from
Oct 23, 2024

Conversation

@cbandy
Copy link
Member

@cbandy cbandy commented Oct 23, 2024

The version of controller-gen we use ignores validation:Required markers when the struct tag has json:"omitempty".

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • Bug fix

Other Information:

Issue: PGO-1748

@cbandy
Remove json:omitempty from required fields
4bfe5b5 
This version of controller-gen ignores "validation:Required" markers
when the struct tag has "json:omitempty".

Issue: PGO-1748
@cbandy cbandy requested a review from dsessler7 October 23, 2024 20:31
dsessler7
dsessler7 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@dsessler7 dsessler7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbandy cbandy merged commit 1bca41c into CrunchyData:master Oct 23, 2024
12 of 15 checks passed
@cbandy cbandy deleted the required-fields branch October 23, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsessler7 dsessler7 dsessler7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbandy @dsessler7